Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ert queue options #9486

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

oyvindeide
Copy link
Collaborator

@oyvindeide oyvindeide commented Dec 9, 2024

Currently the queue options have to be kept manually in sync between the server and the simulator, while we also just have one long list of options, where we mix slurm, lsf and pbs related keywords. This bundles these together to simplify the configuration and the backend by just using the QueueOptions directly.

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@oyvindeide oyvindeide force-pushed the use_ert_queue_options branch 8 times, most recently from 40d3659 to 44b1e73 Compare December 11, 2024 21:50
@codecov-commenter
Copy link

codecov-commenter commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.85%. Comparing base (4301b63) to head (8570b6d).

Files with missing lines Patch % Lines
src/ert/scheduler/__init__.py 70.00% 3 Missing ⚠️
src/everest/config/server_config.py 84.61% 2 Missing ⚠️
src/ert/gui/simulation/experiment_panel.py 50.00% 1 Missing ⚠️
src/everest/config/everest_config.py 91.66% 1 Missing ⚠️
src/everest/config/simulator_config.py 90.90% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9486      +/-   ##
==========================================
- Coverage   91.86%   91.85%   -0.01%     
==========================================
  Files         433      431       -2     
  Lines       26762    26695      -67     
==========================================
- Hits        24584    24521      -63     
+ Misses       2178     2174       -4     
Flag Coverage Δ
cli-tests 39.76% <43.75%> (-0.01%) ⬇️
everest-models-test 34.64% <73.21%> (-0.03%) ⬇️
gui-tests 72.11% <50.00%> (-0.01%) ⬇️
integration-test 37.12% <75.00%> (-0.12%) ⬇️
performance-tests 51.96% <50.00%> (ø)
test 40.29% <76.78%> (-0.18%) ⬇️
unit-tests 74.19% <53.57%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oyvindeide oyvindeide force-pushed the use_ert_queue_options branch 6 times, most recently from bc1e0d6 to caa83a1 Compare December 13, 2024 07:05
@oyvindeide oyvindeide marked this pull request as ready for review December 13, 2024 07:06
@oyvindeide oyvindeide force-pushed the use_ert_queue_options branch from caa83a1 to f5b5619 Compare December 13, 2024 07:18
@oyvindeide oyvindeide force-pushed the use_ert_queue_options branch from f5b5619 to 8570b6d Compare December 13, 2024 07:45
@oyvindeide oyvindeide added the release-notes:breaking-change Automatically categorise as breaking change in release notes label Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
christmas-review release-notes:breaking-change Automatically categorise as breaking change in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants