-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ert queue options #9486
Open
oyvindeide
wants to merge
4
commits into
equinor:main
Choose a base branch
from
oyvindeide:use_ert_queue_options
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use ert queue options #9486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oyvindeide
force-pushed
the
use_ert_queue_options
branch
8 times, most recently
from
December 11, 2024 21:50
40d3659
to
44b1e73
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9486 +/- ##
==========================================
- Coverage 91.86% 91.85% -0.01%
==========================================
Files 433 431 -2
Lines 26762 26695 -67
==========================================
- Hits 24584 24521 -63
+ Misses 2178 2174 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
oyvindeide
force-pushed
the
use_ert_queue_options
branch
6 times, most recently
from
December 13, 2024 07:05
bc1e0d6
to
caa83a1
Compare
oyvindeide
force-pushed
the
use_ert_queue_options
branch
from
December 13, 2024 07:18
caa83a1
to
f5b5619
Compare
oyvindeide
force-pushed
the
use_ert_queue_options
branch
from
December 13, 2024 07:45
f5b5619
to
8570b6d
Compare
oyvindeide
added
the
release-notes:breaking-change
Automatically categorise as breaking change in release notes
label
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
christmas-review
release-notes:breaking-change
Automatically categorise as breaking change in release notes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the queue options have to be kept manually in sync between the server and the simulator, while we also just have one long list of options, where we mix slurm, lsf and pbs related keywords. This bundles these together to simplify the configuration and the backend by just using the QueueOptions directly.
git rebase -i main --exec 'pytest tests/ert/unit_tests -n logical -m "not integration_test"'
)When applicable